SONARJAVA-5942 Fix CI: use Java 21 in plugin QA and bump SpotBugs to 4.9.8.2 #5384
Conversation
hashicorp-vault-sonar-prod
bot
changed the title
tomasz-tylenda-sonarsource
force-pushed
the
tt/ci
branch
from
9c49b77 to
176d0e5
Compare
tomasz-tylenda-sonarsource
changed the title
tomasz-tylenda-sonarsource
requested review from
dorian-burihabwa-sonarsource and
leonardo-pilastri-sonarsource
dorian-burihabwa-sonarsource
left a comment
dorian-burihabwa-sonarsource
left a comment
There was a problem hiding this comment.
The change looks good to me but I am wondering if we could remove the versioning from the plugin invocation in the test for easier maintenance
.github/workflows/build.yml
Outdated
| - name: Select Java 17 | ||
| run: mise use java@17 | ||
| - name: Select Java 21 | ||
| run: mise use java@21 |
There was a problem hiding this comment.
It might be a little early to switch all plugin QA to Java 21 but at least that's work we won't have to do for the LTA
There was a problem hiding this comment.
I changed the config, so that we keep running LATEST_RELEASE with Java 17.
| MavenBuild build = TestUtils.createMavenBuild().setPom(TestUtils.projectPom("spotbugs-external-report")) | ||
| .setProperty("sonar.java.spotbugs.reportPaths", "target" + File.separator + "spotbugsXml.xml") | ||
| .setGoals("clean package com.github.spotbugs:spotbugs-maven-plugin:4.5.3.0:spotbugs", "sonar:sonar"); | ||
| .setGoals("clean package com.github.spotbugs:spotbugs-maven-plugin:4.9.8.2:spotbugs", "sonar:sonar"); |
There was a problem hiding this comment.
Do we need to specify the version of the plugin here? My understanding is that because the plugin is versioned in the pom.xml of the project, this is redundant. Or am I missing something?
There was a problem hiding this comment.
I'm not a maven expert. I dropped the version and the CI passes, so I guess we can do this.
tomasz-tylenda-sonarsource
force-pushed
the
tt/ci
branch
from
47160b9 to
a42114c
Compare
|
2 participants
No description provided.